Merge pull request #22 from davewalker5/FR-94-External-Flight-Lookup-Api #126
davewalker5
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
13 warnings
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/setup-java@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
src/FlightRecorder.BusinessLogic/Api/FlightRecorderHttpClient.cs#L13
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
src/FlightRecorder.Tests/Mocks/MockHttpClient.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
src/FlightRecorder.BusinessLogic/Api/FlightRecorderHttpClient.cs#L13
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
src/FlightRecorder.BusinessLogic/Database/SightingManager.cs#L105
Remove this commented out code.
|
|
build:
src/FlightRecorder.BusinessLogic/Logic/SightingManager.cs#L105
Remove this commented out code.
|
|
build:
src/FlightRecorder.BusinessLogic/Api/ExternalApiBase.cs#L85
Change this expression which always evaluates to the same result.
|
|
build:
src/FlightRecorder.DataExchange/Import/AirportImporter.cs#L15
Make this field 'private' and encapsulate it in a 'public' property.
|
|
build:
src/FlightRecorder.DataExchange/Import/SightingsImporter.cs#L15
Make this field 'private' and encapsulate it in a 'public' property.
|
|
build:
src/FlightRecorder.DataExchange/Import/AirportImporter.cs#L24
Pass a timeout to limit the execution time.
|
|
build:
src/FlightRecorder.DataExchange/Import/SightingsImporter.cs#L24
Pass a timeout to limit the execution time.
|
|
build:
src/FlightRecorder.Tests/Mocks/MockHttpClient.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
build:
src/FlightRecorder.BusinessLogic/Api/FlightRecorderHttpClient.cs#L13
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|