Fix iOS v8 runtime crashing #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #83
This should fix issue #83 when running with an iOS v8 runtime >7.0.6 and/or with latest nativescript/core.
I couldn't figure it out exactly why, but the objc marshaller was crashing with a bad pointer access when trying to wrap the native object params for the button handler methods. Since the native event param was not being used, simply removing it was sufficient to fix the crash.
I also rearranged the button handler implementation/declaration to be more in line with the rest of the nativescript core components (which should hopefully improve garbage collection in theory).