Skip to content

Commit

Permalink
v1.2.2 No longer showing config page on start up if the authenticatio…
Browse files Browse the repository at this point in the history
…n token is missing
  • Loading branch information
davidCburke authored and davecburke committed Sep 9, 2024
1 parent b8fd919 commit c2ba3c2
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = function(grunt) {
const version = '1.2.1';
const version = '1.2.2';
// Project configuration.
grunt.initConfig({
pkg: grunt.file.readJSON('package.json'),
Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ SilverBullet Clipper uses the following libraries:
- Storage: used to save extension options.

# Version History

## 1.2.2

- No longer showing config page on start up if the authentication token is missing

## 1.2.1

- Changed where the page is saved in SilverBullet to match SilverBullet's new Inbox file structure. The page was saved in the Inbox folder with the datetime stamp as the default page name. eg 2024-09-07 16:08:45. The new structure is Inbox/yyyy-mm-dd/hh-mm-ss.md. eg Inbox/2024-09-07/16-08-45
Expand Down
4 changes: 1 addition & 3 deletions dist/chrome/js/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ document.addEventListener("DOMContentLoaded", () => {
displayTitle();
//Prompt to provide credentials if they are missing
chrome.storage.sync.get(["hostURL", "token", "directory", "appendPageTitleDefault", "saveMetadataAsFrontmatterDefault"]).then(items => {
if(items === null || items.hostURL === null || items.hostURL === ''
|| items.token === null || items.token === ''
|| items.directory === null || items.directory === '')
if(items === null || items.hostURL === null || items.hostURL === '' || items.directory === null || items.directory === '')
{
hideCapture();
showConfigure();
Expand Down
2 changes: 1 addition & 1 deletion dist/chrome/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "SilverBullet Clipper",
"version": "1.2.1",
"version": "1.2.2",
"manifest_version": 3,
"description": "SilverBullet Clipper captures a web page URL or selected content, converts it to markdown and saves it in the SilverBullet Inbox",
"icons": {
Expand Down
4 changes: 1 addition & 3 deletions dist/firefox/js/popup.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ document.addEventListener("DOMContentLoaded", () => {
displayTitle();
//Prompt to provide credentials if they are missing
browser.storage.sync.get(["hostURL", "token", "directory", "appendPageTitleDefault", "saveMetadataAsFrontmatterDefault"]).then(items => {
if(items === null || items.hostURL === null || items.hostURL === ''
|| items.token === null || items.token === ''
|| items.directory === null || items.directory === '')
if(items === null || items.hostURL === null || items.hostURL === '' || items.directory === null || items.directory === '')
{
hideCapture();
showConfigure();
Expand Down
2 changes: 1 addition & 1 deletion dist/firefox/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "SilverBullet Clipper",
"version": "1.2.1",
"version": "1.2.2",
"manifest_version": 2,
"description": "SilverBullet Clipper captures a web page URL or selected content, converts it to markdown and saves it in the SilverBullet Inbox",
"icons": {
Expand Down
4 changes: 1 addition & 3 deletions src/js/popup.template.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ document.addEventListener("DOMContentLoaded", () => {
displayTitle();
//Prompt to provide credentials if they are missing
<%= runTime %>.storage.sync.get(["hostURL", "token", "directory", "appendPageTitleDefault", "saveMetadataAsFrontmatterDefault"]).then(items => {
if(items === null || items.hostURL === null || items.hostURL === ''
|| items.token === null || items.token === ''
|| items.directory === null || items.directory === '')
if(items === null || items.hostURL === null || items.hostURL === '' || items.directory === null || items.directory === '')
{
hideCapture();
showConfigure();
Expand Down

0 comments on commit c2ba3c2

Please sign in to comment.