-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-connection support #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port_num should always be 1.
Add APIs for `Rdma` to create a new `Rdma` that has the same `mr_allocator` and `event_listener` as parent. Change server and client examples to add multi-connection APIs demo.
Add `CloneAttr` to define the behaviors that occur during `clone` before `listen` or `new_connect`.
`tcache` is a feature of `Jemalloc` to speed up memory allocation. However `Jemalloc` may alloc `MR` with wrong `arena_index` from `tcache` when we create more than one `Jemalloc` enabled `mr_allocator`s. So we disable `tcache` by default.
Prepare for multi-connection with multi-pd.
Set new `ProtectionDomain` for new `Rdma` to provide isolation.
We can use `set_max_rmr_access` to set the maximum permission on `RemoteMr` that the remote end can request.
Set new max access permission for remote mr requests for new `Rdma` by `set_new_max_rmr_access`
rogercloud
reviewed
Aug 31, 2022
Place access in a separate file and hide `ibv_access_flags` for users. Users should not touch the underlying details about `ibv_access_flags`. Because it may change with `rdma-sys` bindings.
rogercloud
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.