Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log verification to support assetsv2 and eventsv1 event verification #15

Merged
merged 19 commits into from
Dec 13, 2024

Conversation

honourfish
Copy link
Contributor

@honourfish honourfish commented Dec 11, 2024

Overview

  • add eventsv2 to logverification
  • move verifiableevent into assetsv2
  • make the remaining code generic using VerifiableLogEntry or VerifiableMMREntry interface

Testing

  • Existing unit tests pass

New and old merklelog systemtests pass (using assetsv2 and eventsv1 events)

./e2estorageconfig.test \
  -test.v \
  2>&1 | go-junit-report -set-exit-code -debug.print-events > test_results/./e2estorageconfig.test-xunit.xml

{"type":"run_test","name":"TestE2EStorageConfigSuite"}
{"type":"run_test","name":"TestE2EStorageConfigSuite/TestE2EReadOnlyStorage"}
{"type":"end_test","name":"TestE2EStorageConfigSuite","result":"PASS","duration":260000000}
{"type":"end_test","name":"TestE2EStorageConfigSuite/TestE2EReadOnlyStorage","result":"PASS","duration":250000000,"indent":1}
{"type":"status","result":"PASS"}
{"type":"output","data":"coverage: [no statements]"}
task: [test:go:system:run] 
mkdir -p test_results

./e2esealverification.test \
  -test.v \
  2>&1 | go-junit-report -set-exit-code -debug.print-events > test_results/./e2esealverification.test-xunit.xml

{"type":"run_test","name":"TestE2ESealVerificationSuite"}
{"type":"run_test","name":"TestE2ESealVerificationSuite/TestE2ESealVerification"}
{"type":"end_test","name":"TestE2ESealVerificationSuite","result":"PASS","duration":5970000000}
{"type":"end_test","name":"TestE2ESealVerificationSuite/TestE2ESealVerification","result":"PASS","duration":5960000000,"indent":1}
{"type":"status","result":"PASS"}
{"type":"output","data":"coverage: [no statements]"}
task: [test:go:system:run] 
mkdir -p test_results

./e2elogtoevent.test \
  -test.v \
  2>&1 | go-junit-report -set-exit-code -debug.print-events > test_results/./e2elogtoevent.test-xunit.xml

{"type":"run_test","name":"TestE2ELogToEventSuite"}
{"type":"run_test","name":"TestE2ELogToEventSuite/TestE2ELogToEvent"}
{"type":"output","data":"73:38: 93bb606f7d032500"}
{"type":"end_test","name":"TestE2ELogToEventSuite","result":"PASS","duration":9790000000}
{"type":"end_test","name":"TestE2ELogToEventSuite/TestE2ELogToEvent","result":"PASS","duration":9790000000,"indent":1}
{"type":"status","result":"PASS"}
{"type":"output","data":"coverage: [no statements]"}
task: [test:go:system:run] 
mkdir -p test_results

./e2ebenchmark.test \
  -test.v \
  2>&1 | go-junit-report -set-exit-code -debug.print-events > test_results/./e2ebenchmark.test-xunit.xml

{"type":"run_test","name":"TestE2EBenchmarkSuite"}
{"type":"run_test","name":"TestE2EBenchmarkSuite/TestE2EPublicBenchmark"}
{"type":"output","data":"permissioned committed duration (secs):  1"}
{"type":"output","data":"public committed duration (secs):  2"}
{"type":"output","data":"permissioned confirmed duration (secs):  3"}
{"type":"output","data":"public confirmed duraton (secs):  4"}
{"type":"end_test","name":"TestE2EBenchmarkSuite","result":"PASS","duration":6140000000}
{"type":"end_test","name":"TestE2EBenchmarkSuite/TestE2EPublicBenchmark","result":"PASS","duration":6130000000,"indent":1}
{"type":"status","result":"PASS"}
{"type":"output","data":"coverage: [no statements]"}
task: [test:go:system:run] 
mkdir -p test_results

./e2eintegrity.test \
  -test.v \
  2>&1 | go-junit-report -set-exit-code -debug.print-events > test_results/./e2eintegrity.test-xunit.xml

{"type":"run_test","name":"TestE2EIntegritySuite"}
{"type":"run_test","name":"TestE2EIntegritySuite/TestE2EIntegrity"}
{"type":"run_test","name":"TestE2EIntegritySuite/TestE2EIntegrityEventsV1"}
{"type":"run_test","name":"TestE2EIntegritySuite/TestE2EPublicIntegrity"}
{"type":"end_test","name":"TestE2EIntegritySuite","result":"PASS","duration":13860000000}
{"type":"end_test","name":"TestE2EIntegritySuite/TestE2EIntegrity","result":"PASS","duration":5130000000,"indent":1}
{"type":"end_test","name":"TestE2EIntegritySuite/TestE2EIntegrityEventsV1","result":"PASS","duration":1240000000,"indent":1}
{"type":"end_test","name":"TestE2EIntegritySuite/TestE2EPublicIntegrity","result":"PASS","duration":7480000000,"indent":1}
{"type":"status","result":"PASS"}
{"type":"output","data":"coverage: [no statements]"}
task: [test:go:system:run] 
mkdir -p test_results

./systests.test \
  -test.v \
  2>&1 | go-junit-report -set-exit-code -debug.print-events > test_results/./systests.test-xunit.xml

{"type":"output"}
{"type":"output","data":"Environment: {TestIDPKey:hO3n3ix4Wq8WgnUdhHlVfWoWJRdbSo6x FQDN:https://app.dev-jgough-0.dev.datatrails.ai MerklelogAccountName:jitavid82dae51e7978891a MerklelogURL:https://jitavid82dae51e7978891a.blob.core.windows.net/ PublicTenantID:tenant/3bad0c96-e1b7-7b35-98ca-1a8ede13ee10 MerkelogURLPrefix:verifiabledata PublicKey:-----BEGIN PUBLIC KEY-----"}
{"type":"output","data":"MHYwEAYHKoZIzj0CAQYFK4EEACIDYgAEbBPhBjEt9H+AA6oD/D3Tkn3q5DEz2enB"}
{"type":"output","data":"X4dTkh0/Rr1KRYGKU/i84ELM+jgJAKuHNRr8Nj8OoUf/voYkuTJDv/FFx6xZxyLm"}
{"type":"output","data":"urBdpiimXreuBlTgdzE6AlZNBLp6Empg"}
{"type":"output","data":"-----END PUBLIC KEY-----"}
{"type":"output","data":"}"}
{"type":"run_test","name":"TestNewTestEnv"}
{"type":"run_test","name":"TestNewTestEnv/positive"}
{"type":"end_test","name":"TestNewTestEnv","result":"PASS"}
{"type":"end_test","name":"TestNewTestEnv/positive","result":"PASS","indent":1}
{"type":"status","result":"PASS"}
{"type":"coverage","coverage_percentage":3.8}

re: AB#10260

@robinbryce
Copy link
Contributor

great work, thanks!

Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@honourfish honourfish requested a review from wp0pw December 13, 2024 09:31
@honourfish honourfish merged commit 973e5c4 into main Dec 13, 2024
1 check passed
@honourfish honourfish deleted the dev/jgough/10260-logentry-v1 branch December 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants