Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/jgough/8503 keyvault keys #9

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Dev/jgough/8503 keyvault keys #9

merged 3 commits into from
Sep 27, 2023

Conversation

honourfish
Copy link
Contributor

@honourfish honourfish commented Sep 27, 2023 •
edited by ghost
Loading

Overview

  • Add keyvault client for managing keyvault keys

Testing

  • Unit tested where we implement logic
  • Manually tested functions that called into the keyvault rest API

AB#8503

Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

eccles
eccles approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@eccles eccles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point a Logger should be added to the KeyVault struct but this can wait

@honourfish honourfish merged commit f1467c3 into main Sep 27, 2023
1 check passed
@honourfish honourfish deleted the dev/jgough/8503-keyvault-keys branch September 27, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eccles eccles eccles approved these changes

@robinbryce robinbryce Awaiting requested review from robinbryce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honourfish @eccles