Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tenant id from metrics #67

Merged
merged 1 commit into from
May 8, 2024

Conversation

eccles
Copy link
Member

@eccles eccles commented May 2, 2024

The tenantid is no longer a label on latency metrics.

Additionally corrected the generated mocks for azbus.

AB#8906

@eccles eccles force-pushed the dev/paul/8906-remove-tenantid-from-metrics branch from 3776c24 to 0428a15 Compare May 2, 2024 14:42
@eccles eccles requested review from waarg, j-hartley and landintrees May 2, 2024 14:43
landintrees
landintrees previously approved these changes May 2, 2024
Copy link

@landintrees landintrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eccles eccles force-pushed the dev/paul/8906-remove-tenantid-from-metrics branch 2 times, most recently from 3693609 to e4a80a9 Compare May 3, 2024 08:59
Copy link

@waarg waarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The tenantid is no longer a label on latency metrics.

Additionally corrected the generated mocks for azbus.

AB#8906
@eccles eccles force-pushed the dev/paul/8906-remove-tenantid-from-metrics branch from e4a80a9 to d602252 Compare May 7, 2024 17:06
@eccles eccles merged commit 5543067 into main May 8, 2024
2 checks passed
@eccles eccles deleted the dev/paul/8906-remove-tenantid-from-metrics branch May 8, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants