Quality checks #30
Merged
Quality checks #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honourfish
reviewed
Nov 3, 2023
honourfish
reviewed
Nov 3, 2023
honourfish
reviewed
Nov 3, 2023
eccles
force-pushed
the
dev/paul/8685-panic
branch
from
90a6e4a to
ecacf12
Compare
eccles
force-pushed
the
dev/paul/8685-panic
branch
4 times, most recently
from
370e5e5 to
e59759c
Compare
Check listener for nil and nil value and return error. Check ChainHandler for nil and nil value and return error. Check ChainHandler for returned nil and return error. Some extra logging AB#8685
eccles
force-pushed
the
dev/paul/8685-panic
branch
from
e59759c to
e7e8fe2
Compare
honourfish
reviewed
Nov 14, 2023
honourfish
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check listener for nil and nil value and return error.
Check ChainHandler for nil and nil value and return error.
Check ChainHandler for returned nil and return error.
Some extra logging
AB#8685