Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST Proxy Server #25

Merged
merged 2 commits into from
Oct 26, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! REST Proxy Server
Paul Hewlett committed Oct 25, 2023
commit 56218e5695cbec4528ffc0a87f46aedb97460cb9
4 changes: 2 additions & 2 deletions grpcserver/grpcserver.go
Original file line number Diff line number Diff line change
@@ -64,9 +64,9 @@ func tracingFilter(ctx context.Context, fullMethodName string) bool {
return true
}

// NewGRPCServer cretaes a new GRPCServer that is bound to a specific GRPC API. This object complies with
// New cretaes a new GRPCServer that is bound to a specific GRPC API. This object complies with
// the standard Listener service and can be managed by the startup.Listeners object.
func NewGRPCServer(log Logger, name string, opts ...GRPCServerOption) GRPCServer {
func New(log Logger, name string, opts ...GRPCServerOption) GRPCServer {
listenStr := fmt.Sprintf(":%s", env.GetOrFatal("PORT"))

health := grpchealth.New(log)
2 changes: 1 addition & 1 deletion restproxyserver/restproxyserver.go
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ func WithGRPCAddress(a string) RESTProxyServerOption {
}
}

// WikthRegisterHandler adds another grpc-gateway handler
// WithRegisterHandler adds another grpc-gateway handler
func WithRegisterHandler(r RegisterRESTProxyServer) RESTProxyServerOption {
return func(g *RESTProxyServer) {
g.registers = append(g.registers, r)