fixes to deal with the limitations of mongodb, grpc-gatway and bson #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: oneof doesn't play well with grpc gateway (apparently) Instead of the (much cleaner) oneof, we will have a single message in the event per proof mech. only one of them will be present in any event fix: mongo cant store unsigned integers of any size So we use a different message for storing the proof details for mongo. It encodes the idtimestamp as a fixed lenght hex string. this preserves the sortable and comparible properties. For now we keep the other unsigned types as they wont use the full range of bits until a single tenant log has 2^63 events in it. fix: the field ordinals for merkle log messages were benignly 'wrong'. All message fields for merkle log messages start at ordinal 1 now AB#8859
honourfish
reviewed
Jan 19, 2024
honourfish
reviewed
Jan 19, 2024
honourfish
reviewed
Jan 19, 2024
honourfish
approved these changes
Jan 19, 2024
robinbryce
deleted the
dev/robin/8859-assetconfirmer-forestrie-changes-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: oneof doesn't play well with grpc gateway (apparently)
Instead of the (much cleaner) oneof, we will have a single message in the event per proof mech. only one of them will be present in any event
fix: mongo cant store unsigned integers of any size
So we use a different message for storing the proof details for mongo. It encodes the idtimestamp as a fixed lenght hex string. this preserves the sortable and comparible properties.
For now we keep the other unsigned types as they wont use the full range of bits until a single tenant log has 2^63 events in it.
fix: the field ordinals for merkle log messages were benignly 'wrong'. All message fields for merkle log messages start at ordinal 1 now
AB#8859