forestrie trust level updates supporting confirmation of forestrie events #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robinbryce
commented
Jan 13, 2024
•
robinbryce
commented
- Add the confirmation states representing the forestrie trust levels as described here: https://github.com/datatrails/epic-8120-scalable-proof-mechanisms/blob/main/event-trust-levels.md
- Add a oneof to EventResponse to take the proof_details for the merklelog proof mechanism
- Add the necessary proto messages to support forestrie notifying assetstorev2confirmer of event confirmationstatus COMMITTED
- Fix the include paths for openapiv2
- simplify the include path discovery
- add docker-all target for people who don't want to build on their host (which is a lot faster)
- export the proto dependencies under proto-include so consumers of go-datatrails-common-api do not need to replicate the location and fetching of same
robinbryce
force-pushed
the
dev/robin/8859-assetconfirmer-forestrie-changes
branch
2 times, most recently
from
09fbfff to
1d3689f
Compare
* Add the confirmation states representing the forestrie trust levels as described here: https://github.com/datatrails/\ epic-8120-scalable-proof-mechanisms/blob/main/event-trust-levels.md * Add the provisional extra details we need in the event for the MERKLE_LOG proof mechanism * Use a single oneof per proof mech details fix: the include paths for openapiv2 build: simplify the include path discovery build: export the proto dependencies under proto-include This means consumers do not need to replicate the tricky go list based include path discovery ci: add a job to check the dockerall task works But note this is disabled due to acr permissions issues For people who can't or wont install protoc and go AB#8859 remove fields that are not settled yet use oneof for proof_details
robinbryce
force-pushed
the
dev/robin/8859-assetconfirmer-forestrie-changes
branch
from
da042e2 to
db8ea99
Compare
robinbryce
changed the title
honourfish
reviewed
Jan 15, 2024
honourfish
reviewed
Jan 15, 2024
wp0pw
reviewed
Jan 15, 2024
honourfish
reviewed
Jan 15, 2024
wp0pw
reviewed
Jan 15, 2024
honourfish
previously approved these changes
Jan 15, 2024
build: use 'local-all' as the native host target and reserve 'all' for people who want no surprises fix: committed -> commit for the field carrying the log commit info move the forestrie CONFIRMED comment to the original CONFIRMED constant and remove the confusing duplicate
honourfish
approved these changes
Jan 15, 2024
robinbryce
deleted the
dev/robin/8859-assetconfirmer-forestrie-changes
branch
wp0pw
reviewed
Jan 15, 2024
|
|
||
|
|
||
| // The details stored in the SaaS db for a proof mech MERKLE_LOG commitment | ||
| message MerklLogEntry { |
There was a problem hiding this comment.
should this be MerkleLogEntry? and also can we do same with commited -> commit here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.