fix: 10263 don't explode for bad option values #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also expand the test coverage to fully cover verification modes. Positive and negative cases for `--leaf`, `--entryid` and `--event-json-file` Negative *tamper* case for `--event-json-file` AB#10263
eccles
reviewed
Dec 12, 2024
eccles
reviewed
Dec 12, 2024
added 2 commits
December 12, 2024 15:03
make all the main's return ints and use the sys.exit(main()) idiom note that test need to be posix status aware as a consequence
eccles
approved these changes
Dec 12, 2024
robinbryce
deleted the
dev/robin/10263-verify-reciept-handle-bad-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expand the test coverage to fully cover verification modes.
Positive and negative cases for
--leaf,--entryidand--event-json-fileNegative tamper case for
--event-json-fileAB#10263