Fix a case sensitivity issue when fetching the clustering order #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapcod
reviewed
Mar 9, 2021
| @@ -1361,7 +1361,7 @@ def create_table_options(table_data, compaction_strategy, is_compact) | |||
| def create_column(column_data, types) | |||
| name = column_data['column_name'] | |||
| is_static = column_data['kind'].to_s.casecmp('STATIC').zero? | |||
| order = column_data['clustering_order'] == 'desc' ? :desc : :asc | |||
| order = column_data['clustering_order'].to_s.casecmp('DESC').zero? ? :desc : :asc | |||
There was a problem hiding this comment.
Why not use casecmp? ? It would allow to write it like this:
column_data['clustering_order'].to_s.casecmp?('DESC') ? :desc : :ascThere was a problem hiding this comment.
@kapcod Sure! I wrote it like that just to be consistent with the style of the line above which uses casecmp('STATIC').zero?. But I can change it with casecmp? (which is more straightforward) if you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this issue when using the driver with a Scylla database, which is supposed to use the same protocol. Scylla returns
DESCinstead ofdesc. So I think this fix could handle both cases.