Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-1309 cqlengine: Remove deepcopy on UserType deserialization #1192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Dec 4, 2023

  1. cqlengine: Remove deepcopy on UserType deserialization

    This change makes it so newly instanced UserType during deserialization
    isn't immediately copied by deepcopy, which could cause huge slowdown if
    that UserType contains a lot of data or nested UserTypes, in which case the
    deepcopy calls would cascade as each to_python call would eventually clone
    parts of source object. As there isn't a lot of information on why this
    deepcopy is here in the first place this change could potentially break
    something. Running integration tests against this commit does not produce
    regressions, so this call looks safe to remove, but I'm leaving this
    warning here for the future reference.
    
    Issue: scylladb#152
    k0machi committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b28b879 View commit details
    Browse the repository at this point in the history