Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-1358 Add a TimeUUID class #1175

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SiyaoIsHiding
Copy link
Collaborator

@SiyaoIsHiding SiyaoIsHiding commented Sep 3, 2023

Closes PYTHON-1358. Based on Cassandra's implementation and the issue reporter's code.

I am considering where to put the class TimeUUID and the relevant tests. I currently put them in util.py and test_types.py, which is weird. Any suggestions?

Any requests for changes are welcomed.

@SiyaoIsHiding
Copy link
Collaborator Author

Signed the cla. And do I need to do anything about the Python 2 thing?

@absurdfarce
Copy link
Collaborator

Hey @SiyaoIsHiding , nice to (virtually) see you again! And hey, thanks for the PR! Apologies for the delay in getting back to you; we've been trying to get multiple releases out at the same time and (as usual) we're running behind a bit.

Re: the Python 2 thing... you mean the AppVeyor build + tests, right? Yeah, you can completely ignore those for now. The AppVeyor builds for several of the drivers need to be updated so for now that's a no-op... focus on the Travis builds instead.

It looks like this PR is still in draft... are you at a spot where I should be reviewing anything here? Or do you still have some work you want to do on it?

@SiyaoIsHiding
Copy link
Collaborator Author

Hi @absurdfarce , excited to join your team!
No rush on this PR. I was just trying to familiarize myself with the codebase and I understand this issue is a minor priority.

This is still a draft PR because I am considering where to put the class TimeUUID and the relevant tests. I currently put them in util.py and test_types.py, which is kinda weird. Do you have any suggestions?

Again, no rush at all. And looking forward to working with you in the team soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants