added License and Label models #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanmajchrak
approved these changes
Nov 8, 2024
vidiecan
requested changes
Nov 12, 2024
vidiecan
requested changes
Nov 18, 2024
dspace_rest_client/models.py
Outdated
| """ | ||
| Specific attributes and functions for licenses | ||
| """ | ||
| type = 'clarinlicense' |
There was a problem hiding this comment.
I wanted to change it because I understand the reasons, but when I checked the entire file where I added it, each of the classes was made similarly. In this case, wouldn't it be better to do it as the author did?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
After the vanilla import, the tables containing licenses are empty because there were no licenses beforehand.
Analysis
Fetch licenses, labels, and extended mappings from the database where licenses already exist. Filter them based on the definitions that are not required, and import them into vanilla DSpace where they are missing.
Added models for better work with database license fetch.