Internal/fix failing Clarin integration test #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paurikova2
requested changes
Oct 31, 2024
| @@ -276,6 +276,9 @@ public void testShouldReturnDuplicateUserErrorLoginWithoutNetId() throws Excepti | |||
| .andExpect(redirectedUrl("http://localhost:4000/login/duplicate-user?email=" + email)) | |||
| .andReturn().getResponse().getHeader("Authorization"); | |||
|
|
|||
| // Check if was created a user with such email and netid. | |||
| EPerson ePerson = checkUserWasCreated(netId, IDP_TEST_EPERSON, email, null); | |||
| deleteShibbolethUser(ePerson); | |||
There was a problem hiding this comment.
whats about if ePerson is null?
Paurikova2
approved these changes
Oct 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)