Skip to content
This repository has been archived by the owner on Jun 26, 2022. It is now read-only.

update the cobidas checklist jitsi channel #1

Closed
wants to merge 1 commit into from
Closed

update the cobidas checklist jitsi channel #1

wants to merge 1 commit into from

Conversation

Remi-Gau
Copy link

Not ideal "fix" when people (like me) already have a jitsi channel because if you update the json from parsing the tsv again I will have to make another PR but at least I won't have more than one channel to check.

@bpoldrack
Copy link

@Remi-Gau :

How about modifying make_page.py instead?
Just insert after

rec['url'] = f'<a href="https://meet.jit.si/{url}" target="_{url}">{url}</a>'

a line that checks whether the read-in record is your poster and replace the url entry w/ your hardcoded existing one.

@yarikoptic
Copy link
Contributor

ok, the idea for providing "overrides" seems to be most flexible and would allow to change a nicely formatted smaller file. I will produce a stab of that file in a minute. But I will need basic JS help to implement such "overrides" at client side at this point: https://github.com/datalad-datasets/ohbm2020-posters/blob/gh-pages/assets/js/main.js#L439 . But also we would need to adjust invocation there to not just pass a url to the table in ajax.

meanwhile, we will make this json multilined for more sensible patching... we will deal with merging changes if regenerated later...

@yarikoptic
Copy link
Contributor

@Remi-Gau please just post poster number, URL and may be URL to PDF -- I Am adding overrides functionality now!

@yarikoptic
Copy link
Contributor

I failed to quickly review the diff of the one liner ;)

@Remi-Gau
Copy link
Author

Thanks @bpoldrack and @yarikoptic for the suggestion and looking into this.

@Remi-Gau
Copy link
Author

@Remi-Gau please just post poster number, URL and may be URL to PDF -- I Am adding overrides functionality now!

Would that do?

@yarikoptic
Copy link
Contributor

for now -- yes. later I might want a "pure" downloadable url

@yarikoptic
Copy link
Contributor

all done @Remi-Gau : spread the word. People could send PRs against https://github.com/datalad-datasets/ohbm2020-posters/blob/gh-pages/posters-overrides.json#L3072 like done for yours.

Also would be great if someone resolve #4

@yarikoptic yarikoptic closed this Jun 24, 2020
christian-monch added a commit to christian-monch/ohbm2020-posters that referenced this pull request Jun 25, 2020
- Replace combination characters with single character
- Re-insert deleted NBSP or delete NBSP
- Re-insert cp1252-encoding of properly utf-8 encoded
  character
yarikoptic added a commit that referenced this pull request Jun 25, 2020
* origin/gh-pages:
  I added a web link of the poster nr  1998 by Renzo huber (#32)
  add videochat and pdf to poster 1929 (#34)
  BF: add files generated with proper encoding
  BF: fix encodings, part #2
  BF: fix fault encodings, part #1
  Added link to poster 769 (#30)
  [DATALAD RUNCMD] tools/make_page.py -m 'Produce posters.j...
  Update posters-overrides.json (#29)
  [DATALAD RUNCMD] tools/make_page.py -m 'Produce posters.j...
  pdf for 1930 on behalf of Jo
  Add PDF link for poster #1781 (#26)
  poster link #648
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants