-
Notifications
You must be signed in to change notification settings - Fork 84
update the cobidas checklist jitsi channel #1
update the cobidas checklist jitsi channel #1
Conversation
How about modifying ohbm2020-posters/tools/make_page.py Line 49 in 0b457ce
a line that checks whether the read-in record is your poster and replace the url entry w/ your hardcoded existing one. |
ok, the idea for providing "overrides" seems to be most flexible and would allow to change a nicely formatted smaller file. I will produce a stab of that file in a minute. But I will need basic JS help to implement such "overrides" at client side at this point: https://github.com/datalad-datasets/ohbm2020-posters/blob/gh-pages/assets/js/main.js#L439 . But also we would need to adjust invocation there to not just pass a url to the table in meanwhile, we will make this json multilined for more sensible patching... we will deal with merging changes if regenerated later... |
@Remi-Gau please just post poster number, URL and may be URL to PDF -- I Am adding overrides functionality now! |
I failed to quickly review the diff of the one liner ;) |
Thanks @bpoldrack and @yarikoptic for the suggestion and looking into this. |
Would that do? |
for now -- yes. later I might want a "pure" downloadable url |
all done @Remi-Gau : spread the word. People could send PRs against https://github.com/datalad-datasets/ohbm2020-posters/blob/gh-pages/posters-overrides.json#L3072 like done for yours. Also would be great if someone resolve #4 |
- Replace combination characters with single character - Re-insert deleted NBSP or delete NBSP - Re-insert cp1252-encoding of properly utf-8 encoded character
* origin/gh-pages: I added a web link of the poster nr 1998 by Renzo huber (#32) add videochat and pdf to poster 1929 (#34) BF: add files generated with proper encoding BF: fix encodings, part #2 BF: fix fault encodings, part #1 Added link to poster 769 (#30) [DATALAD RUNCMD] tools/make_page.py -m 'Produce posters.j... Update posters-overrides.json (#29) [DATALAD RUNCMD] tools/make_page.py -m 'Produce posters.j... pdf for 1930 on behalf of Jo Add PDF link for poster #1781 (#26) poster link #648
Not ideal "fix" when people (like me) already have a jitsi channel because if you update the json from parsing the tsv again I will have to make another PR but at least I won't have more than one channel to check.