enclosure addition in feature collection links #230
Conversation
|
retest this please |
| if (success.isEmpty()) { | ||
| LOGGER.error("Collections table is empty!"); | ||
| result.fail( | ||
| new OgcException(404, "Not found", "Collection table is Empty!")); |
There was a problem hiding this comment.
Cannot throw a 404 exception here because /collections is a valid path. If the table is empty just return an empty response or a JsonObject for collections object.
| if (successItem | ||
| .getString("id") | ||
| .equals(enclosure.getString("collections_id"))) { | ||
| if (successItem.containsKey("enclosure")) { |
There was a problem hiding this comment.
How is the successItem having the enclosure key beforehand?
| LOGGER.warn("Assets table is empty!"); | ||
| result.complete(success); | ||
| } else { | ||
| for (JsonObject enclosure : enclosureResult) { |
There was a problem hiding this comment.
Instead of running a double for loop, what you can try and verify is to change the query itself to join the table collections_enclosure and use json_agg(), refer-
|
|
||
| INSERT INTO collections_enclosure (id, collections_id, title, href, type, size) | ||
| SELECT id, stac_collections_id, title, href, type, size | ||
| FROM stac_collections_assets; |
There was a problem hiding this comment.
You can add a truncate statement to the stac_collections_assets table since all the data will now be moved to a new table and all existing rows won't have any relation with the new data that will added in the future.
| "SELECT collections_details.id, title, " | ||
| + "description, bbox, temporal, license FROM collections_details " | ||
| + "JOIN collection_type ON collections_details.id = collection_type.collection_id " | ||
| + "WHERE collection_type.type = 'STAC' AND collections_details.id = $1::uuid GROUP " |
There was a problem hiding this comment.
Why do you require a GROUP BY clause?
/apiwhich are not of type STAC and in/stac/apito include collection of type STAC