[K8s] Resource Server Helm chart rework to use single deployment for all verticles #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
karthickp432001
commented
Sep 2, 2024
karthickp432001
commented
- Modified values.yaml to remove all the verticles except apiServer
- Modified aws and azure resource-values files to have only resources and limits of single verticle
- updated the helm chart
|
Can one of the admins verify this patch? |
karun-singh
requested changes
Sep 25, 2024
| apiVersion: {{ include "common.capabilities.deployment.apiVersion" . }} | ||
| kind: Deployment | ||
| metadata: | ||
| name: rs-async | ||
| name: rs-api-server |
There was a problem hiding this comment.
Change deployment name and labels to resource-server, to avoid confusion. Also matching whats there in HPA
Suggested change
| name: rs-api-server | |
| name: resource-server |
| @@ -20,160 +20,6 @@ apiServer: | |||
| requests: | |||
There was a problem hiding this comment.
Increase the resources since all verticles will run in single pod now.
| @@ -20,160 +20,6 @@ apiServer: | |||
| requests: | |||
There was a problem hiding this comment.
Increase the resources since all verticles will run in single pod now.
karun-singh
requested changes
Sep 25, 2024
| extraEnvVarsCM: "rs-env" | ||
| ## @param async.extraEnvVarsSecret Name of existing Secret containing extra env vars for async nodes | ||
| ## | ||
| extraEnvVarsSecret: "rs-s3-env" |
There was a problem hiding this comment.
We still need to pass this for the async verticle to work, please add it in above resourceServer block.
|
As per the suggestion I have updated the resources in the resource values yaml file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.