data restriction and attribute masking #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TO DO:
|
gopal-mahajan
requested changes
Aug 19, 2024
src/main/java/iudx/resource/server/apiserver/ApiServerVerticle.java
Outdated
Show resolved
Hide resolved
src/main/java/iudx/resource/server/apiserver/handlers/AuthHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/iudx/resource/server/authenticator/authorization/ConsumerAuthStrategy.java
Show resolved
Hide resolved
|
|
||
| int consumedData = quotaConsumed.getInteger("consumed_data"); | ||
| int apiCount = quotaConsumed.getInteger("api_count"); | ||
|
|
There was a problem hiding this comment.
will consumedData apiCount always be int or should it be float? @Gokul-KG
| handler.handle(Future.failedFuture(responseBuilder.getResponse().toString())); | ||
| return; | ||
| } | ||
| if (!isUsageWithinLimits(authInfo, answer.getLong("size"))) { |
There was a problem hiding this comment.
In this scenario, if a user has a search ID that has already been audited, and they have a usage limit of 500 MB which has been fully consumed for that search ID, what happens if they attempt to access the resource again? Since their remaining limit is now zero, should we allow them to access the resource that has already been audited, or should access be denied? @Gokul-KG @swaminathanvasanth
gopal-mahajan
requested changes
Aug 20, 2024
Comment on lines
440
to
445
| jsonResponse.put("access", access); | ||
| jsonResponse.put("meteringData", meteringData); | ||
| jsonResponse.put("accessPolicy", accessPolicy); | ||
| jsonResponse.put("accessType", ACCESS_MAP.get(endPoint)); | ||
| jsonResponse.put("resourceId", resourceId); | ||
| jsonResponse.put("enableLimits", isLimitsEnabled); // for async status auditing |
There was a problem hiding this comment.
Use constant strings here
src/test/java/iudx/resource/server/authenticator/JwtAuthServiceImplTest.java
Show resolved
Hide resolved
src/test/java/iudx/resource/server/authenticator/JwtAuthServiceImplTest.java
Show resolved
Hide resolved
src/test/java/iudx/resource/server/authenticator/JwtAuthServiceImplTest.java
Show resolved
Hide resolved
…g-service Refactor/metering service
Redis Service Added
jwt leeway time added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes for [Data access restriction]
Quota Limit Enforcement:
Limits data access based on daily API call count and data consumption.[For consumer role]
Attribute Masking Setup:
Controls access to specific data attributes.
Note: Attribute masking feature yet to be implemented for Redis(latest search)