Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DJ for bool support #62

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update DJ for bool support #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ There is primarily 3 things to consider when looking to contribute.

After considering the above, you may comment on the issue you'd like to help fix and a maintainer will assign it to you.

## What is the proper pull request (PR) etiquette?
## What is the proper etiquette for proposing changes as contribution?

What is generally expected from new pull requests are the following:
What is generally expected from new contributions are the following:

- Any proposed contributor changes should be introduced in the form of a pull request (PR) from their fork.
- Proper branch target specified. The following is generally the available branches that can be targeted:
- `master` or `main`: Represents the single source of truth and the latest in completed development.
- `pre`: Represents the source at the point of the last stable release.
Expand All @@ -30,6 +31,8 @@ What is generally expected from new pull requests are the following:
3. No style errors e.g. PEP8, etc.
4. Similar or better code coverage
- Additional documentation to reflect new feature or behavior introduced.
- A contributor should not approve or merge their own PR.
- Reviewer suggestions or feedback should not be directly committed to a branch on contributor's fork. A less intrusive way to collaborate would be for the reviewer to PR to the contributor's fork/branch that is associated with the main PR currently in review.

Maintainers will also ensure that PR's have the appropriate assignment for reviewer, milestone, and project.

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
flask
pyjwt[crypto]
datajoint==0.13.dev4
datajoint==0.13.dev5
datajoint_connection_hub