No curation ephys AND kilosort triggering #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dimitri Yatsenko <[email protected]>
added 10 commits
June 2, 2022 19:15
… neuropixels data
Comment on lines
327
to
329
| self.EphysFile.insert([{**key, | ||
| 'file_path': fp.relative_to(root_dir).as_posix()} | ||
| for fp in probe_data.recording_info['recording_files']]) |
There was a problem hiding this comment.
Suggested change
| self.EphysFile.insert([{**key, | |
| 'file_path': fp.relative_to(root_dir).as_posix()} | |
| for fp in probe_data.recording_info['recording_files']]) | |
| self.EphysFile.insert({**key, | |
| 'file_path': fp.relative_to(root_dir).as_posix()} | |
| for fp in probe_data.recording_info['recording_files']) |
added 9 commits
August 15, 2022 13:53
|
@kabilar should we close this PR? We can issue PR from the |
|
Thanks @ttngu207. That sounds good. Feel free to close and create a new pull request. Let's ask @sidhulyalkar to review and merge. |
CBroz1
reviewed
Sep 15, 2022
| # explicitly garbage collect "loaded_oe" | ||
| # as these may have large memory footprint and may not be cleared fast enough | ||
| del loaded_oe | ||
| gc.collect() |
There was a problem hiding this comment.
@dimitri-yatsenko Your comment on PR #71 is regarding an add from PR #54. PR71 assumes 54 will be merged first, which is why it is marked as draft.
I'm not about the details on garbage collection. Comments here indicate that loaded_oe has significant memory demands
|
Closing this PR - to be replaced by a new PR from the |
kabilar
pushed a commit
to kabilar/element-array-ephys
that referenced
this pull request
Jun 26, 2023
trialized and localization notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34
Fix #40
Fix #37
Fix #39