Fix regex patterns and add minimum version for scikit-image #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ethho would you be able to review this? |
|
@ttngu207 or @kushalbakshi Do you have time to review? I'm not as familiar with this project. cc: @tabedzki |
|
Thanks for bringing this to my attention, @ethho. I should be able to take a look today. |
kushalbakshi
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks @tabedzki. I was able to test the tutorial notebook through Codespaces with your changes and it ran through without any issues. I'll merge this right now but hold off on a release since we're planning for one in the coming weeks. You will still be able to use this by installing the repository directly.
|
Thanks @tabedzki @kushalbakshi @ethho! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two commits. The first commit fixes regex patterns in the code by providing raw annotations for strings with unsupported escape regex sequences. The second commit adds a minimum version requirement for scikit-image in the setup.py file. These changes ensure that the code functions correctly in Python 3.12 and is compatible with the required dependencies.