Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest #185

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Add pytest #185

merged 6 commits into from
Mar 22, 2024

Conversation

JaerongA
Copy link
Collaborator

No description provided.

@JaerongA JaerongA requested a review from ttngu207 March 21, 2024 23:32
@ttngu207 ttngu207 requested a review from kushalbakshi March 21, 2024 23:42
kushalbakshi
kushalbakshi requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pytests look good. Please run Black formatting and increment the version and CHANGELOG so the style tests pass and we're ready to merge into main.

kushalbakshi
kushalbakshi previously approved these changes Mar 22, 2024
View reviewed changes
@kushalbakshi kushalbakshi dismissed their stale review March 22, 2024 20:32

Style tests don't pass. Still needs formatting

@kushalbakshi kushalbakshi merged commit 9299142 into main Mar 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalbakshi kushalbakshi kushalbakshi approved these changes

@ttngu207 ttngu207 Awaiting requested review from ttngu207

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaerongA @kushalbakshi