-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from the discussion on Issue #1 #2
Conversation
…n | add Assembly class as the top level object
@dimitri-yatsenko @iamamutt Please take a look when you guys are available, I made those changes followed by the discussion in Issue 1 |
I think the class design is pretty clear. I think later down the line we may want to simplify |
Points that need to improve:
+neuropixels
to+npxtoolkit
Assembly
class as the top level object, also changedPipeline
toSession
in order to avoid concept conflictsAssembly->Session->Stage->JobBase
assemble()
toadd_session()
to avoid confusionlog4m
at+npxtoolkit/+internal/+logging/