fix(ingest): better handling around sink errors #9003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
treff7es
approved these changes
Oct 24, 2023
| except Exception as e: | ||
| # In case the sink's error handling is bad, we still want to report the error. | ||
| self.sink.report.report_failure( | ||
| f"Failed to write record: {e}" |
There was a problem hiding this comment.
Can log stack trace? I'm a bit concerned about losing information where the error came.
There was a problem hiding this comment.
this is mainly a fallback mechanism if the source doesn't catch the error elsewhere - given that the error handling in the kafka sink has also improved, I think it's ok
hsheth2
added
the
merge-pending-ci
maggiehays
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack ref: https://datahubspace.slack.com/archives/CUMUWQU66/p1696317869262289?thread_ts=1695824642.165599&cid=CUMUWQU66
Checklist