feat(ui/java) Update domains to be nested #8841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
|
|
||
| return CompletableFuture.supplyAsync(() -> { | ||
|
|
||
| // todo - implement parentDomain permissions |
There was a problem hiding this comment.
We don't need to do this todo, I'll push a PR to remove it
There was a problem hiding this comment.
Actually since it's on your branch, can you update it
| @@ -170,7 +170,7 @@ export const ManagePolicies = () => { | |||
| variables: { | |||
| input: { | |||
| start, | |||
| count: pageSize, | |||
| count: pageSize + 10, | |||
There was a problem hiding this comment.
Not sure about this @chriscollins3456 - do you have any recollection?
There was a problem hiding this comment.
oh goodness no lol but I think you committed it in this commit? chriscollins3456@d98cf77#diff-233e1f29c0ac1da442f3d66913b74671aa3416041e03286950edfcc82ff582b2
maybe just for testing purposes?
There was a problem hiding this comment.
Must have been but for the life of me I cannot remember why
joshuaeilers
approved these changes
Sep 14, 2023
chriscollins3456
merged commit 85fa5a1
into
datahub-project:master
59 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the ability to now nest domains underneath other domains. This should work much like the business glossary where you can add domains underneath other domains, move domains underneath other domains or at the root, and navigate domains using a nice new navigator.
Note: Permissions are inherited from parent domains - so if you add permissions to a parent domain and an entity is added to a child domain, that permission is inherited to child domains as well.
Here's some screenshots of the new experience:
Checklist