Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(search) Use search across multiple-entities API, deprecate Aggregator classes #8498

Merged
merged 14 commits into from
Aug 8, 2023
Merged

refactor(search) Use search across multiple-entities API, deprecate Aggregator classes #8498

merged 14 commits into from
Aug 8, 2023

Conversation

iprentic
Copy link
Contributor

@iprentic iprentic commented Jul 24, 2023 •
edited
Loading

  • Added tests to ensure parity with the old functionality w.r.t the legacy entity aggregation group

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Jul 24, 2023
@iprentic iprentic changed the title refactor(search) Use search across multiple-entities API, deprecate Aggregator classes [WIP] refactor(search) Use search across multiple-entities API, deprecate Aggregator classes Jul 25, 2023
@iprentic iprentic changed the title [WIP] refactor(search) Use search across multiple-entities API, deprecate Aggregator classes refactor(search) Use search across multiple-entities API, deprecate Aggregator classes Jul 25, 2023
@iprentic iprentic added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jul 28, 2023
@iprentic iprentic added release-0.11.0 and removed merge-pending-ci A PR that has passed review and should be merged once CI is green. labels Jul 28, 2023
@iprentic iprentic merged commit 926a9c3 into master Aug 8, 2023
35 checks passed
@iprentic iprentic deleted the deprecate-aggregatorss branch August 8, 2023 14:23
yoonhyejin pushed a commit that referenced this pull request Aug 24, 2023
@iprentic @yoonhyejin
refactor(search) Use search across multiple-entities API, deprecate A…
74c04ca 
…ggregator classes (#8498)

Co-authored-by: Indy Prentice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@gabe-lyons gabe-lyons Awaiting requested review from gabe-lyons

@david-leifker david-leifker Awaiting requested review from david-leifker

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX release-0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iprentic @RyanHolstien