fix(dataProduct) Show entity count excluding soft deleted entities #8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaeilers
approved these changes
Jul 18, 2023
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
Outdated
Show resolved
Hide resolved
…l/GmsGraphQLEngine.java Co-authored-by: Joshua Eilers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of assets we were showing on a data product profile page and search result card was just a straight count of the number of urns on its aspect. This was then including soft-deleted entities that don't show up in the Assets tab so the numbers were off.
This utilizes the same resolver that gets those assets from its aspect and performs a search. This auto-filters out soft-deleted entities and is more extensible. Therefore the number at the top of the profile page is coming from the same place that fetches the list of assets in the tab. I'm fetching a
countof0since we don't need any entity results, just the total count - therefore this is more efficient.Checklist