fix(ui) Remove initial redirect logic from frontend

[chriscollins3456]

While this functionality may be useful to some, the majority of feedback we've heard around our redirect logic when first going to datahub is that it's unexpected and undesirable. This PR removes that logic so when you go to the homepage for the first time, that's all that happens (no redirect).

This also fixes a little type in our demo banner.

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[jjoyce0510]

I thought the idea was to support filtering for specific pages to save redirect link for? That is another idea to avoid removing this altogether. For example, if you're editing a doc and did not save it it's really useful to come back to that context.

[jjoyce0510]

Basically, are we throwing the baby out with the bathwater here. Is there any reason to believe in the future that having this logic already there would be helpful? Or if your thinking that we'd dig this out of git history at that point if we feel it's really necessary?

[chriscollins3456]

Basically, are we throwing the baby out with the bathwater here. Is there any reason to believe in the future that having this logic already there would be helpful? Or if your thinking that we'd dig this out of git history at that point if we feel it's really necessary?

@jjoyce0510 thinking we pull this out of git if we want it back! otherwise it's just confusing to leave an unused hook in there if you ask me

[chriscollins3456]

I thought the idea was to support filtering for specific pages to save redirect link for? That is another idea to avoid removing this altogether. For example, if you're editing a doc and did not save it it's really useful to come back to that context.

also I didn't realize this - I thought the thinking was just to remove this for now and if we really want to we can add it back later? tbh all i've heard about this feature is confusion and negativity