Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/fivetran): do not materialise upstream #11806

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Nov 6, 2024

  • Follow up this fix(ingest/fivetran): only materialize upstream lineage #9490 to remove materialisation completely. This led to badly materialised datasets that did not have all the aspects and led to a odd state in the UI without platform instances.
  • This follows the consistent practice that we have adopted of 1 ingestion source not materialising other sources entities

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Hello @anshbansal 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly this materialization was done on purpose previously. Not sure why though, let's try to remember to bring this up to Harshal when he gets back

@anshbansal anshbansal merged commit f13d544 into master Nov 7, 2024
73 checks passed
@anshbansal anshbansal deleted the ab-do-not-materialise-upstream branch November 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants