Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs-site) improvements to home page #11783

Merged
merged 4 commits into from
Nov 4, 2024
Merged

fix(docs-site) improvements to home page #11783

merged 4 commits into from
Nov 4, 2024

Conversation

jayacryl
Copy link
Collaborator

@jayacryl jayacryl commented Nov 4, 2024 •
edited
Loading

Also:

  1. Updated announcement bar copy
  2. Added apple's adoption story
  3. Adoption stories section is draggable now - better for desktop windows users

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Hello @jayacryl 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

@jayacryl jayacryl changed the title fix(docs-site) adoption stories draggable now fix(docs-site) improvements to home page Nov 4, 2024
maggiehays
maggiehays approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@maggiehays maggiehays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayacryl jayacryl merged commit e53a54e into master Nov 4, 2024
38 checks passed
@jayacryl jayacryl deleted the jp--announcement branch November 4, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggiehays maggiehays maggiehays approved these changes

@yoonhyejin yoonhyejin Awaiting requested review from yoonhyejin

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayacryl @maggiehays