feat(ingest/datahub): Add way to filter soft deleted entities #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add way to filter aspects
github-actions
bot
added
the
ingestion
hsheth2
approved these changes
Oct 29, 2024
| exclude_aspects: Set[str] = Field( | ||
| default_factory=set, | ||
| description="Set of aspect names to exclude from ingestion", | ||
| ) |
There was a problem hiding this comment.
I assume we use a set here instead of an AllowDenyPattern so that we can push down the filters to sql?
metadata-ingestion/src/datahub/ingestion/source/datahub/config.py
Outdated
Show resolved
Hide resolved
| {"" if self.config.include_all_versions else "AND mav.version = 0"} | ||
| {"" if not self.config.exclude_aspects else f"AND LOWER(mav.aspect) NOT IN %(exclude_aspects)s"} | ||
| AND mav.createdon >= %(since_createdon)s | ||
| ORDER BY createdon, urn, aspect, version |
There was a problem hiding this comment.
can we indent the subquery here - otherwise the sql is hard to read
also - I like how we format sql queries in the fivetran source
- I'd like to move towards this type of formatting everywhere| AND mav.createdon >= %(since_createdon)s | ||
| ORDER BY createdon, urn, aspect, version | ||
| ) as t | ||
| where row_id > %(last_id)s |
There was a problem hiding this comment.
why are we doing manual pagination instead of just using db cursors?
| @@ -92,6 +92,23 @@ def __init__( | |||
| **connection_config.options, | |||
| ) | |||
|
|
|||
| @property | |||
| def soft_deleted_urns(self) -> str: | |||
There was a problem hiding this comment.
Suggested change
| def soft_deleted_urns(self) -> str: | |
| def soft_deleted_urns_query(self) -> str: |
| "Cannot exclude soft deleted entities without a database connection" | ||
| ) | ||
| soft_deleted_urns = [ | ||
| row[0] for row in database_reader.get_soft_deleted_rows() |
There was a problem hiding this comment.
will this read the soft-deleted urns list twice?
metadata-ingestion/src/datahub/ingestion/source/datahub/datahub_kafka_reader.py
Outdated
Show resolved
Hide resolved
|
Merging as the error is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to filter soft-deleted entities
Add a way to filter aspects
Fix SQL query pagination to not have duplicate entries
Checklist