Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): reduce minimum length filter from 3 to 2 characters #11722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(search): reduce minimum length filter from 3 to 2 characters #11722

wants to merge 1 commit into from

Conversation

sokojh
Copy link

@sokojh sokojh commented Oct 28, 2024

Modify elasticsearch filter settings for shorter search terms

Change min length parameter from 3 to 2 in SettingsBuilder.java to allow shorter search terms.

Changes

  • Modified min_length parameter in elasticsearch filter settings from 3 to 2
  • This change improves search functionality for multilingual environments

issue #11721

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@sokojh
fix(search): reduce minimum length filter from 3 to 2 characters
29e3f82 
modify elasticsearch filter settings to allow shorter search terms
change min length parameter from 3 to 2 in SettingsBuilder.java

Improves search functionality by allowing shorter search terms in multilingual environments
@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 28, 2024
@sokojh
Copy link
Author

sokojh commented Nov 8, 2024

Hello @chriscollins3456

I submitted this PR a week ago and would appreciate your feedback when possible. Please let me know if you need any additional information or changes from my side.

Thanks for maintaining this great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sokojh