fix(ui): show ingested entities in ingestion report when ingestion succeeded with warnings #11704
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cceeded with warnings
github-actions
bot
added
product
gabe-lyons
approved these changes
Nov 12, 2024
|
Thank you @Masterchen09 - I will merge this for you! |
Masterchen09
deleted the
fix-ingestion-report-succeeded-with-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ingested entities are not shown in the ingestion report of the UI when the ingestion succeeded with warnings...it should be save to show the ingested entities in these cases, because the ingestion was still "successful"...
There is somewhere a report regarding this bug (either in GitHub or in Slack), but am not able to find anymore. 🤷♂️
Checklist