Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Superset Dataset Ingestion/Lineage #11687

Closed
wants to merge 34 commits into from

Conversation

hwmarkcheng
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Description:

Draft PR to enrich Superset Ingestion with relevant metadata
Superset has useful metadata in relation to superset physical (Raw table, 1:1 with say redshift table) /virtual (Custom sql) datasets, e.g owners, their own schema fields, custom sql, etc.

The current iteration of superset ingestion simply just links to the schema/table specified in the API (Which can be inaccurate, especially for virtual datasets). We've added a few changes to enrich the ingestion process.

  • Creates Dataset Entity for each physical/virtual dataset in Superset
  • Added Schema fields for charts
  • SQL parsing for virtual datasets
  • Lineage for tables (including virtual datasets), table level lineage for virtual datasets are accurate
  • Column level lineage (Working, but low accuracy on retrieving some columns, improvement will likely have to be another contribution)
  • Tagging for physical/virtual datasets
  • Retrieves owners and metrics from dataset/charts to sync in (WIP, Will map Preset owners to datahub owners, metrics to glossary terms)

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 22, 2024
@hwmarkcheng
Copy link
Contributor Author

Seems like our fork is out of sync, will look to resync first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants