Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/prefect): Fix prefect mypy errors #11680

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Oct 21, 2024

asyncio.iscoroutine was unneded as it called an async function:

https://github.com/PrefectHQ/prefect/blob/afbed19d752b7057ccb2dc63ab806f56cc563fe1/src/prefect/client/orchestration.py#L1832

https://github.com/PrefectHQ/prefect/blob/afbed19d752b7057ccb2dc63ab806f56cc563fe1/src/prefect/client/orchestration.py#L1613

https://github.com/PrefectHQ/prefect/blob/afbed19d752b7057ccb2dc63ab806f56cc563fe1/src/prefect/client/orchestration.py#L1832

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 21, 2024
@david-leifker david-leifker merged commit 16f9075 into datahub-project:master Oct 21, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants