Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ingest/redshift): limit copy lineage #11662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 17, 2024

This limits it to a max of 20 entries per table, which means that we can't get overwhelmed by lineage entries for tables with ultra-high traffic.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This limits it to a max of 20 entries per table, which means that we
can't get overwhelmed by lineage entries for tables with ultra-high
traffic.
@hsheth2 hsheth2 changed the title feat(ingest/redshift): limit copy lineage perf(ingest/redshift): limit copy lineage Oct 17, 2024
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 17, 2024
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

c.file_name AS filename,
ROW_NUMBER() OVER (
PARTITION BY sti."schema", sti."table"
ORDER BY si.start_time ASC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use DESC in favour of getting latest rows ?

@mayurinehate mayurinehate added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants