-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add access aspect for dashboards #11624
Open
githendrik
wants to merge
5
commits into
datahub-project:master
Choose a base branch
from
githendrik:feature/add-access-management-aspect-to-dashboards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[feat] add access aspect for dashboards #11624
githendrik
wants to merge
5
commits into
datahub-project:master
from
githendrik:feature/add-access-management-aspect-to-dashboards
+36
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
PR or Issue related to the DataHub UI/UX
community-contribution
PR or Issue raised by member(s) of DataHub Community
labels
Oct 15, 2024
@githendrik looks like there's some lint issues here |
My bad, sorry. Fixed them now. I had only run spotlessApply for the Java related changes. |
@jayacryl - hey, I'm not sure if this PR is missing something else. Could you help me out maybe? :) Thanks! |
Failing checks read like network / connectivity issues unrelated to this PR - unless I'm mistaken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the Access Management feature of Datahub in our organisation and saw that this aspect is not currently supported for Dashboards. This PR aims to change that.
Checklist