Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add access aspect for dashboards #11624

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

githendrik
Copy link
Contributor

We use the Access Management feature of Datahub in our organisation and saw that this aspect is not currently supported for Dashboards. This PR aims to change that.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 15, 2024
@githendrik
Copy link
Contributor Author

@haeniya fyi, depending on which PR gets merged first, we might need to sync/resolve conflicts.
@hsheth2 as I believe you were reviewing @haeniya s PR and are in the loop. No changes to any ingestions in this PR though, just adding the aspect to dashboards.

@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 16, 2024

@githendrik looks like there's some lint issues here

@hsheth2 hsheth2 requested a review from jayacryl October 16, 2024 01:10
@githendrik
Copy link
Contributor Author

@githendrik looks like there's some lint issues here

My bad, sorry. Fixed them now. I had only run spotlessApply for the Java related changes.

@githendrik
Copy link
Contributor Author

@jayacryl - hey, I'm not sure if this PR is missing something else. Could you help me out maybe? :) Thanks!

@githendrik
Copy link
Contributor Author

Failing checks read like network / connectivity issues unrelated to this PR - unless I'm mistaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants