fix(ingest/sql-server): update queries to use escaped procedure name (#…

…9127)
datahub-project · Oct 27, 2023 · 5166d90 · 5166d90
1 parent 379ffc8
commit 5166d90
Show file tree

Hide file tree

Showing 6 changed files with 1,324 additions and 763 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/mssql/source.py b/metadata-ingestion/src/datahub/ingestion/source/sql/mssql/source.py
@@ -530,7 +530,7 @@ def _get_procedure_inputs(
     def _get_procedure_code(
         conn: Connection, procedure: StoredProcedure
     ) -> Tuple[Optional[str], Optional[str]]:
-        query = f"EXEC [{procedure.db}].dbo.sp_helptext '{procedure.full_name}'"
+        query = f"EXEC [{procedure.db}].dbo.sp_helptext '{procedure.escape_full_name}'"
         try:
             code_data = conn.execute(query)
         except ProgrammingError:
@@ -567,7 +567,7 @@ def _get_procedure_properties(
                 create_date as date_created,
                 modify_date as date_modified
             FROM sys.procedures
-            WHERE object_id = object_id('{procedure.full_name}')
+            WHERE object_id = object_id('{procedure.escape_full_name}')
             """
         )
         properties = {}