Skip to content

Commit

Permalink
feat(ingest/cli): add undo soft delete command (#11740)
Browse files Browse the repository at this point in the history
  • Loading branch information
anshbansal authored Nov 4, 2024
1 parent 95f361a commit 1f02c84
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
11 changes: 11 additions & 0 deletions metadata-ingestion/src/datahub/cli/delete_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,17 @@ def references(urn: str, dry_run: bool, force: bool) -> None:
logger.info(f"Deleted {references_count} references to {urn}")


@delete.command()
@click.option("--urn", required=True, type=str, help="the urn of the entity")
def undo_by_filter(urn: str) -> None:
"""
Undo a soft deletion of an entity
"""
graph = get_default_graph()
logger.info(f"Using {graph}")
graph.set_soft_delete_status(urn=urn, delete=False)


@delete.command(no_args_is_help=True)
@click.option(
"--urn",
Expand Down
17 changes: 16 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/graph/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1241,14 +1241,29 @@ def soft_delete_entity(
Args:
urn: The urn of the entity to soft-delete.
"""
self.set_soft_delete_status(
urn=urn, run_id=run_id, deletion_timestamp=deletion_timestamp, delete=True
)

def set_soft_delete_status(
self,
urn: str,
delete: bool,
run_id: str = _GRAPH_DUMMY_RUN_ID,
deletion_timestamp: Optional[int] = None,
) -> None:
"""Change status of soft-delete an entity by urn.
Args:
urn: The urn of the entity to soft-delete.
"""
assert urn

deletion_timestamp = deletion_timestamp or int(time.time() * 1000)
self.emit(
MetadataChangeProposalWrapper(
entityUrn=urn,
aspect=StatusClass(removed=True),
aspect=StatusClass(removed=delete),
systemMetadata=SystemMetadataClass(
runId=run_id, lastObserved=deletion_timestamp
),
Expand Down

0 comments on commit 1f02c84

Please sign in to comment.