add data observer

datagovsg · Aug 1, 2016 · 8fdd104 · 8fdd104
1 parent e4ca986
commit 8fdd104
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -7,6 +7,18 @@ A [PolymerJS](https://www.polymer-project.org) custom element for rendering inte
 bower install vega-element
 ```
 
+# important note
+
+You need to import the d3, d3-layout-cloud, geo-projection, topojson dependencies separately (in the right order) for vega to include the plugins properly.
+
+e.g. 
+```
+<link rel="import" href="./d3.html">
+<link rel="import" href="./d3-layout-cloud.html">
+<link rel="import" href="./vega-element.html">
+
+```
+
 # documentation
 
 Details and demo can be found at the [Component Page](https://datagovsg.github.io/vega-element)
diff --git a/es5/vega-behavior.js b/es5/vega-behavior.js
@@ -110,7 +110,7 @@
       }
     },
 
-    observers: ["parse(spec)", "updateSignal(signal,view)", "getData(requestData,view)", "_updateSignalListeners(_diff.added,_diff.removed,view)"],
+    observers: ["parse(spec)", "updateSignal(signal,view)", "getData(requestData,view)", "_updateSignalListeners(_diff.added,_diff.removed,view)", '_updateData(view,data)'],
 
     /*
      * Parse a Vega JSON specification or URL. Updates the **_chart** attribute.  Automatically called when **spec** is updated.
@@ -158,6 +158,11 @@
       return this.lastData;
     },
 
+    _updateData: function _updateData(view, data) {
+      if (!view || !data) return;
+      view.data(data).update({ duration: 800 });
+    },
+
     _observeSignalsChanged: function _observeSignalsChanged(val, old) {
       this._diff = this._difference(val, old);
     },

diff --git a/es6/vega-behavior.html b/es6/vega-behavior.html
@@ -116,7 +116,8 @@
       "parse(spec)",
       "updateSignal(signal,view)",
       "getData(requestData,view)",
-      "_updateSignalListeners(_diff.added,_diff.removed,view)"
+      "_updateSignalListeners(_diff.added,_diff.removed,view)",
+      '_updateData(view,data)'
     ],
 
 
@@ -162,6 +163,10 @@
       return this.lastData;
     },
 
+    _updateData: function(view,data){
+      if (!view || !data) return;
+      view.data(data).update({duration:800});
+    },
 
     _observeSignalsChanged: function(val,old){
       this._diff = this._difference(val,old);

diff --git a/vega-behavior.html b/vega-behavior.html
@@ -114,7 +114,7 @@
       }
     },
 
-    observers: ["parse(spec)", "updateSignal(signal,view)", "getData(requestData,view)", "_updateSignalListeners(_diff.added,_diff.removed,view)"],
+    observers: ["parse(spec)", "updateSignal(signal,view)", "getData(requestData,view)", "_updateSignalListeners(_diff.added,_diff.removed,view)", '_updateData(view,data)'],
 
     /*
      * Parse a Vega JSON specification or URL. Updates the **_chart** attribute.  Automatically called when **spec** is updated.
@@ -162,6 +162,11 @@
       return this.lastData;
     },
 
+    _updateData: function _updateData(view, data) {
+      if (!view || !data) return;
+      view.data(data).update({ duration: 800 });
+    },
+
     _observeSignalsChanged: function _observeSignalsChanged(val, old) {
       this._diff = this._difference(val, old);
     },