Skip to content
This repository has been archived by the owner on Feb 4, 2020. It is now read-only.

Linter auto-fix everything #444

Merged
merged 4 commits into from
Nov 24, 2017
Merged

Linter auto-fix everything #444

merged 4 commits into from
Nov 24, 2017

Conversation

joelchoo
Copy link
Contributor

Key changes:

  1. Disabled angular eslint plugin. It is broken.
  2. Excluded scripts directory for now. Should it have different linter rules? (e.g. ignore no-console?)

@joelchoo joelchoo self-assigned this Nov 24, 2017
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-fix, should be okay

@joelchoo
Copy link
Contributor Author

FYI I made a PR to eslint-plugin-angular which will fix our crashing issue.

EmmanuelDemey/eslint-plugin-angular#518

@joelchoo joelchoo merged commit f50b26c into master Nov 24, 2017
@joelchoo
Copy link
Contributor Author

Just an update: my PR got merged into the development branch! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants