Add child places for all allowed place types and sort them #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnoble
approved these changes
Jan 2, 2025
gmechali
changed the title
dwnoble
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some places did not have a name which caused an error when we tried to get the name property. See https://autopush.datacommons.org/browser/nuts/LVZZ
Discussed whether to keep the restriction for related place charts on only one child_place_type and we decided to drop the requirement. The old place page didnt have it, and the new one would show significantly changed child places. Some countries use EurostatNuts1 while others use AA1. Now we show children of different type and dedupe them.
See Latvia:
Old Place Page: https://screenshot.googleplex.com/BjiMRDVEqQpXEZK
New Place Page before: https://screenshot.googleplex.com/3L6ot765jxM4AjT
New place page after: https://screenshot.googleplex.com/A4kBUEaGitVkum4
Sources tile no longer shown on load:
Before: https://screenshot.googleplex.com/8RGHgDKNTBQKoYD
After: https://screenshot.googleplex.com/9L6AA9XWVYgEgjW