Skip failing custom dc tests. #4820
Conversation
keyurva
commented
Dec 27, 2024
keyurva
commented
- Certain place explorer tests are failing on custom DC autopush. This PR skips those tests for now.
- The failures are likely due to recent place explorer page changes that have probably not been ported to custom DC.
- Filed b/386405593 to fix and unskip them subsequently.
- Also filed b/386405338 to run these tests on each PR so they are caught at the outset.
keyurva
force-pushed
the
ignore-tests
branch
from
8cf03a2 to
6d65ced
Compare
| from server.webdriver.shared_tests.place_explorer_i18n_test import \ | ||
| PlaceI18nExplorerTestMixin | ||
|
|
||
|
|
||
| class TestPlaceExplorerI18n(PlaceI18nExplorerTestMixin, CdcAutopushTestBase): | ||
| """Class to test the i18n place explorer page for Custom DC. Tests come from PlaceI18nExplorerTestMixin.""" | ||
|
|
||
| @unittest.skip(reason=SKIPPED_TEST_REASON) |
There was a problem hiding this comment.
Just a quick note: we already have an approach for skipping unit tests in custom DC. You can remove the test from the shared_tests mixin and add it directly to the main DC /tests/ package instead. Here's an example example
There was a problem hiding this comment.
Thanks for the note. In these 2 cases I don't know if we actually want to remove them or fix and keep them in custom DC. I'll work with Gabe in the new year to figure it out.
Skipping them explicitly for now to stop the alerts until then.
There was a problem hiding this comment.
I think what is done here is better because if this test passes on base dc we should keep it! We definitely should fix this test for custom dc. I like the way keyur did it here!
Also I think we ve had enough instances of breaking auto push cdc with these webdriver tests. We should really try to have these run on a local cdc as well.
There was a problem hiding this comment.
Sounds good—skipping for now makes sense
There was a problem hiding this comment.
@gmechali agreed. is testing against autopush helpful, or should these tests only run against a local cdc?
There was a problem hiding this comment.
I'd argue it's still useful since it allows us to test what's deployed in autopush and catch bugs pre releases
But yeah local would probably be a bit more valuable since we d catch it even earlier
There was a problem hiding this comment.
Thanks both for chiming in!
