Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the see all data sources chip into the link chip group #4803

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

gmechali
Copy link
Contributor

Move variant to be a property of the LinkChip to allow different chips, within one LinkChips group to have different styles.
Move the see all datasources chip to be part of the LinkChips

Before: https://screenshot.googleplex.com/C6nx5vJgmeFB2Tn
After: https://screenshot.googleplex.com/3thzGojXK8xAzZ5

…s, within one LinkChips group to have different styles.
@gmechali gmechali requested a review from dwnoble December 17, 2024 21:22
@dwnoble dwnoble requested a review from miss-o-soup December 17, 2024 21:35
@gmechali gmechali marked this pull request as ready for review December 17, 2024 21:41
@gmechali gmechali merged commit 51b1207 into datacommonsorg:master Dec 17, 2024
9 checks passed
@gmechali gmechali deleted the movechip branch December 17, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants