Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated place page redirect so it keeps the user's locale #4802

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Updated place page redirect so it keeps the user's locale #4802

merged 5 commits into from
Dec 18, 2024

Conversation

dwnoble
Copy link
Contributor

@dwnoble dwnoble commented Dec 17, 2024 •
edited
Loading

Fixes issue where searching from a localized place page (like https://datacommons.org/place/country/USA?hl=fr) always sends you to a place page in English

  • Updated website "base" app to load locale for the header and footer components
  • Updated flask templates to set locale in base.html's #metadata-base[data-locale] to make locale setting consistent with other metadata props.
  • Added locale loading to dev place page
  • Added place, units, and stat var labels locale files to explore page. These locale files keep the explore page from showing errors about missing translations during the place page redirect.

@dwnoble dwnoble requested review from juliawu and gmechali December 17, 2024 20:20
@dwnoble dwnoble merged commit e700af2 into datacommonsorg:master Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmechali gmechali gmechali approved these changes

@juliawu juliawu Awaiting requested review from juliawu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwnoble @gmechali