2024-11-14 Custom DC stable release #4734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add multi-hop properties needed for the hero queries - Update multi-hop properties where naming has changed from data cleanup - Update entity overview tile to link to the browser page for ease of testing
…onsorg#4714) Hopefully this will resolve custom DC autopush test failures.
- Remove some landing page example links that don't work anymore - Add parallelization for Custom DC autopush tests - Add some waiting for elements to be ready in tests that were failing on Cloud Build
- when multiple entities are recognized but only some entities have data for the property, should only show the entities with data (e.g., [autopush](https://screenshot.googleplex.com/48VaUAxjZtXYMgC) vs [local](https://screenshot.googleplex.com/Brsnuj4DSNmpJSN)) - fix bug in deciding when to show low confidence message. Previously did not consider property score
…hm. (datacommonsorg#4716) Places like Curaçao, España, or Algérie were being unfairly demoted in scoring due to the non-ascii character. This PR replaces all special characters before determine the match score. Screencast with the fix: https://screencast.googleplex.com/cast/NDkzOTc5NTE5MjA4NjUyOHw1N2FlYTVmMC00Zg
…tacommonsorg#4718) Reduces CosineScores to 6 decimals to reduce the diffs that are generated when updating the integration_test goldens. This is to reduce noise in reviews and should not fundamentally affect the actual tests.
n-h-diaz
changed the title
|
I think we can update the description to just say that the commits in this release shouldn't actually affect custom DC! Also sorry for the slow review, we should probably update the date in the title too. |
hqpho
approved these changes
Nov 14, 2024
n-h-diaz
changed the title
|
Closing this PR since there are updates needed for merge queue |
github-merge-queue
bot
removed this pull request from the merge queue due to a manual request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this release shouldn't affect custom DC