Add a chart picker util #3622
Open
Add a chart picker util #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shifucun
reviewed
Sep 19, 2023
juliawu
approved these changes
Sep 25, 2023
| rel="stylesheet" | ||
| href="https://dev.datacommons.org/css/datacommons.min.css" | ||
| /> | ||
| <script src="https://dev.datacommons.org/datacommons.js"></script> |
There was a problem hiding this comment.
To confirm, are we standardizing dev.datacommons.org as the goto source for web components? (Are we going to keep pushing latest webcomponent changes to dev?)
| stacked: bool = False, | ||
| lollipop: bool = False, | ||
| horizontal: bool = False): | ||
| vars_str = ' '.join(vars[:5]) |
There was a problem hiding this comment.
Suggestion: extract the 5 to a constant
| f'parentPlace="{ctx.place}"', | ||
| f'childPlaceType="{ctx.child_type}"', | ||
| f'variables="{vars_str}"', | ||
| 'maxPlaces="10"', |
There was a problem hiding this comment.
Suggestion: extract the 10 to a constant
| f'parentPlace="{ctx.place}"', | ||
| f'childPlaceType="{ctx.child_type}"', | ||
| f'variable="{v}"', | ||
| 'rankingCount=10', |
There was a problem hiding this comment.
rankingCount isn't supported by the web components yet so this line and line 171 will get ignored.
There was a problem hiding this comment.
Update: working on adding this now, we can leave this in for now!
chejennifer
approved these changes
Sep 25, 2023
| <head> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://dev.datacommons.org/css/datacommons.min.css" |
There was a problem hiding this comment.
I believe dan made changes where we don't need to include the style sheet anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.